fix(services): reset expanded row state when searching#397
Open
fix(services): reset expanded row state when searching#397
Conversation
When a service row was expanded and the user typed a search query, the expanded state wasn't cleared. This caused data-has-expanded to remain on the table, dimming all rows to 0.35 opacity (gray). Co-Authored-By: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a service row is expanded (selected) and the user types a search query,
expandedIdswas never cleared. This leftdata-has-expandedon the table wrapper, which appliesopacity: 0.35to all non-expanded rows — making everything look gray.Changes
useEffectinServicesPagethat resetsexpandedIdswheneverdebouncedSearchorselectedCategorychangesTesting
Repro: expand a service row → type in search → all results appear grayed out. After fix, expanding state clears on search and rows render at full opacity.
Co-Authored-By: Alexey Shekhirin 5773434+shekhirin@users.noreply.github.com
Prompted by: alexey