RC #855
Open
RC #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/pages/native/balance/SendConfirm.vue:134
- [nitpick] Verify that the success message for CLEOS transactions is clear to users, as it is different from the standard broadcast case.
if (transaction.wasBroadcast) {
src/i18n/en-us/index.js:533
- [nitpick] Ensure that the message is consistent with the application's tone and provides clear guidance for the next steps.
execute_cleos_command: 'Execute your transaction in CLEOS to proceed',
src/pages/native/BalanceInfo.vue:268
- Since the duplicate token filtering logic has been removed, please confirm that the UI or subsequent processing handles potential duplicate tokens appropriately.
const tokens = userCoins.data.tokens.filter((token) => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Description
This PR removes the filter for duplicated symbol tokens. Also removes unused code and fixes some wrong indentations.
Fixes #118
Description
This PR fixes the message displayed when instead of actually sending a signed transaction the cleos authenticator is used.