Skip to content

Conversation

@Viterbo
Copy link
Contributor

@Viterbo Viterbo commented Feb 10, 2025

Fixes #848

Description

There's a filter used to fetch a specific transactions page, and it is remembered until the next fetch attempt. If that filter remains the same, the actual fetch does not happen.

The problem with logging out and logging in again is that this remembered filter was not cleared on logout.

Test scenarios

  • Go to https://deploy-preview-849--wallet-staging.netlify.app
  • Login using Metamask
  • go to the Transactions tab
    • You should see the transactions first page
  • Log out, Login and go again to Transactions tab
    • You should see the transactions' first page again
  • Refresh the page without leaving
    • You should see the transactions' first page again

Screenshots

image

@Viterbo Viterbo linked an issue Feb 10, 2025 that may be closed by this pull request
@Viterbo Viterbo self-assigned this Feb 10, 2025
@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 58a01bd
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/67aa057111c95f0008875994
😎 Deploy Preview https://deploy-preview-849--wallet-develop-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title Transaction history is always fetched #848 | Transaction history is always fetched Feb 10, 2025
@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 58a01bd
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/67aa0571816a3c00080cbe9c
😎 Deploy Preview https://deploy-preview-849--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus self-requested a review February 10, 2025 14:42
@pmjanus pmjanus merged commit 023c8f0 into develop Feb 10, 2025
9 checks passed
@pmjanus pmjanus deleted the 848-transaction-history-not-working-propertly branch February 10, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction History not working propertly

3 participants