Skip to content

Conversation

@JuanMartinP
Copy link
Collaborator

#14
Add config and .env files.

@fgalan
Copy link
Member

fgalan commented Jan 14, 2026

Two comments:

  • A config.md doc file should be included about configuration
  • It is a common practise in our platform to plefix env vars with the name of the componente (e.g. ORION_ in the case of CB). In this case, I'd suggest to use FDA_ (except for NODE_ENV... not sure if we prefix it in other components, pls check)

@AlvaroVega
Copy link
Member

I guess here we can and all env vars needed for postgresql, mongo, minio, aws (tipical endpoint and credentials) as well as fda would need (port, .. ).

@fgalan
Copy link
Member

fgalan commented Jan 15, 2026

I guess here we can and all env vars needed for postgresql, mongo, minio, aws (tipical endpoint and credentials) as well as fda would need (port, .. ).

I agree

In general, all that now is hardwired in the code should be exposed in configuration.

@@ -0,0 +1,56 @@
# Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be linked from main README.md (documentation section)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in commit f00af80

doc/config.md Outdated
- [Introduction](#introduction)
- [Variables](#variables)
- [Environment](#environment)
- [Postgre](#postgre)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postgre, Postgres or PostgreSQL? Which one is the proper term?

(I tend to think it is PostgreSQL)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well after research apparently postgre is the only one no one uses. I thought it was the correct abbreviation but Postgres was the original name of the product so its what's usually used. Changed to PostgreSQL in the commit 341e5f2.

.env.example Outdated
Comment on lines 29 to 32
FDA_POSTGRE_CLIENT_USER=exampleUser
FDA_POSTGRE_CLIENT_PASSWORD=examplePass
FDA_POSTGRE_CLIENT_HOST=exampleHost
FDA_POSTGRE_CLIENT_PORT=5432
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use

FDA_PG_...

?

as we did recently in Kafnurs (e.g. KAFNUS_TESTS_PG_USER)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in commit 608ada7

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and pass ball to @fgalan

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 218d8f6 into main Jan 20, 2026
1 of 2 checks passed
@fgalan fgalan deleted the config-file branch January 20, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants