Issue#253954 Feat: Search program users based on the userIds#57
Open
Sachintechjoomla wants to merge 2 commits intotekdi:developfrom
Open
Issue#253954 Feat: Search program users based on the userIds#57Sachintechjoomla wants to merge 2 commits intotekdi:developfrom
Sachintechjoomla wants to merge 2 commits intotekdi:developfrom
Conversation
vaivk369
reviewed
Mar 4, 2026
|
|
||
| // Original behavior: get mapped users | ||
| const result = await programUsersService.searhProgramUsers( | ||
| if (userIds.length === 0) { |
Collaborator
There was a problem hiding this comment.
@Sachintechjoomla userIds is not the mandatory parameter. If passed in the body you need to use it.
vaivk369
reviewed
Mar 4, 2026
vaivk369
reviewed
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These recommendations are intended to promote code quality and team communication during software development. They cover a variety of topics, including ensuring that pull requests are submitted to the correct branch, documenting new methods, preserving consistency across many services, and avoiding typical blunders like accessing APIs or DB queries within loops. Sensitive data should not be uploaded, and changes to environment variables or database models should be executed consistently. Teams may work more effectively and develop higher-quality software by adhering to these standards.
Type of change
Please choose appropriate options.
Checklist