Merge in (and fix) KeyPhact's U6 implementation#182
Open
dmadisetti wants to merge 48 commits intotejado:masterfrom
Open
Merge in (and fix) KeyPhact's U6 implementation#182dmadisetti wants to merge 48 commits intotejado:masterfrom
dmadisetti wants to merge 48 commits intotejado:masterfrom
Conversation
Update proto
Put semicolons back so it compiles
Based on newest proto
Fixing path issues
Added functions to generate the hashes and hashArray required for u6
Update utilities.py
another line to change
update to reflect renaming in proto
forgot to pass in the authticket
Fixed mistake in generateRequests
Fix Signature.proto
Quick fix to utilities functions
Quick fix to utilities functions
Added wrapper for signature encryption
changed request altitude to int value
Alternatively rebase with https://github.com/tejado/pgoapi if he accepts my commit.
pgoapi/pgoapi.py
Outdated
| def activate_signature(self, lib_path): | ||
| self._signature_lib = lib_path | ||
|
|
||
| def get_signature_lib(self): |
Contributor
Author
There was a problem hiding this comment.
Totally preference, but properties are awesome http://docs.quantifiedcode.com/python-anti-patterns/correctness/implementing_java-style_getters_and_setters.html
Python3 compatibility and Pep8 fixes
Use binascii's unhexlify (already imported) to decode the hex since using `decode` results in an AttributeError in Python 3.
Fix hex decoding in Python 3
|
For Python 3 compatibility, merge or cherry-pick pogodevorg/pgoapi@75eba6b and then pogodevorg/pgoapi@6b50289. |
* added scripts\accept-tos.py * tidied up accept-tos.py
Add a sane API timeout.
correctly return the new access_token after refresh
Add proxy support
Add auth service as an optional parameter
…irement Added future as a requirement
* Uses auth_info as seed when auth_ticket is unavailable This is what the client does too. * combined if statements
The proxy code got left behind when sessions were moved to the PGoApi object, so I applied it to the new sessions and simplified the code.
|
Is this going to get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to do this right?