Fix: Fabric Telemetry not using Correct Methods#127
Open
itscainnotkain wants to merge 2 commits intotebexio:2.3.0-devfrom
Open
Fix: Fabric Telemetry not using Correct Methods#127itscainnotkain wants to merge 2 commits intotebexio:2.3.0-devfrom
itscainnotkain wants to merge 2 commits intotebexio:2.3.0-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.getName()returns "Server" on Fabric, and this has been causing some confusion with analytics. This PR switches it out to useplugin.getPlatform().getType().toString()on all Telemetry calls. There is currently some mix and match between the SDK and the Fabric platforms, long-term it should be using the SDK but this is a temporary fix for right now until the SDK gets fully implemented.