Add missing docstrings across autoprimenet and gimps_status#34
Merged
tdulcet merged 2 commits intotdulcet:devfrom Mar 28, 2026
Merged
Add missing docstrings across autoprimenet and gimps_status#34tdulcet merged 2 commits intotdulcet:devfrom
tdulcet merged 2 commits intotdulcet:devfrom
Conversation
Cover math.prod fallback, Windows/macOS/Linux OS helpers, autoconfig placeholder replacer, GpuOwl NTT and prime-count helpers in Savefle parsing, debug_info, and the same helpers in gimps_status.
Contributor
Author
|
These are really a product of me using tools to learn more about python when done in a proper way. If you don't like these changes or do not want to deal with them, please feel free to ignore them. I won't mind. I appreciate the work you do for the project and GIMPS in geneal. |
tdulcet
approved these changes
Mar 28, 2026
Owner
tdulcet
left a comment
tdulcet
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks like I need to get into a better habit of adding docstrings when I add new functions.
I dropped your second commit with the Ruff autofixes, as some of those changes would break compatibility with older versions of Python. Most of those errors could be ignored with a noqa comment.
tdulcet
pushed a commit
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover math.prod fallback, Windows/macOS/Linux OS helpers, autoconfig placeholder replacer, GpuOwl NTT and prime-count helpers in Savefle parsing, debug_info, and the same helpers in gimps_status.