Conversation
Package Changes Through b991589There are 2 changes which include recent-doc with major, recent-doc-js with major Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks for working on this! Didn't quite try it yet, just some early feedbacks from first glance
We'll also want to add this to the CI
https://github.com/tauri-apps/plugins-workspace/blob/v2/.github/workflows/test-rust.yml
plugins/recent-doc/permissions/autogenerated/commands/execute.toml
Outdated
Show resolved
Hide resolved
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
|
Hi, sorry for being late! I've now apply all the suggestions to the plugin, please have a look at the changes! |
|
@Legend-Master Hi, I've formatted the code and updated the branch. Please run the rest workflows for the branch. |
|
@Legend-Master Sorry for forgetting to fix the broken lockfile. New commit has been submitted. Please run it again. |
Legend-Master
left a comment
There was a problem hiding this comment.
There're still some reviews unresolved from #3131 (review)
And we'll also want to add this to the CI
Just a note that the audit CI fails are unrelated
|
Suggestions in the review applied. |
|
@Legend-Master But the audits in the CI failed. I've updated the dependencies in package.json, but it's confusing that the vulnerabilities are still detected. |
|
@Legend-Master The If you want to test it on your pc, please run There is only one problem left: The jump list in GUI menu doesn't flush after cleaning, though I've tried For now the best way to flush it is to manually turn off the "Show recommended files in Start, recent files in File Explorer, and items in Jump Lists" button and turn back on, which will destroy all the apps' jump list and reset 'em. And this is a user-side action, irrelevant to our implementaion :-/. |
|
All the methods seem to work for me now, trying with the installed version and selecting it as the file association of a test extension (.tauri-test)
Didn't have any problems from my testing, maybe it's related to if the app's installed or not? Anyways, good job! Let's document the behaviors and requirements And we could also expose these methods on the rust side The Mac implementation will need a review from either @FabianLars or @lucasfernog |
Blame my machine. It's ok if it works on yours. |
|
@FabianLars @lucasfernog Hi, now the new plugin is ready for testing on macos. |
1b3ce51 to
b991589
Compare
|
Sorry, I forgot to sign my commits. So I take a force push to resign it. |
@Legend-Master @FabianLars Hey, just a simple test on macos, the APIs works as expected too. |
…pace into feat/recent-doc
This reverts commit 2498834.
9808cdd to
02739c7
Compare




add recent documents api support for issue tauri-apps/tauri#14460
now only available for macos and windows
Closes tauri-apps/tauri#14567