Ignore |- token before first row and not at line beginning
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table row separator should on its own line close tatuylonen/wiktextract#1509
kristian-clausal
approved these changes
Nov 26, 2025
Collaborator
kristian-clausal
left a comment
kristian-clausal
left a comment
There was a problem hiding this comment.
Thanks for catching this, this looks good to me, and it works.
Took me a while because I was looking at the wrong test in wiktextract. But yeah, |- should always be on its own line, but maybe there's special handling on the wikimedia side that ignores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table row separator should on its own line
close tatuylonen/wiktextract#1509, close tatuylonen/wiktextract#1510
Before this change an extra table cell node with text "-" is parsed, el extractor code shouldn't need to change. I have tested that el edition page and the forms data have the correct tags.