|| inside table should be parsed as one cell
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
You might need to upgrade ruff, I had the same problem with the linter being mean to me. The format specs have been changed. |
kristian-clausal
approved these changes
Oct 21, 2025
On Wiktionary, `||` at the line beginning inside a table is expanded to a single `<td>` HTML element. Previous code produces an extra empty table cell node and makes it more difficult for extractor code to decide whether to discard the cell. `test_table_hdr4` was added in commit 1f48e90 for en edition page "山 歩き" and the extracted forms list is the same after this change.
Collaborator
Author
|
I forget to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Wiktionary,
||at the line beginning inside a table is expanded to a single<td>HTML element. Previous code produces an extra empty table cell node and makes it more difficult for extractor code to decide whether to discard the cell.test_table_hdr4was added in commit 1f48e90 for en edition page "山 歩き" and the extracted forms list is the same after this change.