Fix TypeError when streaming empty file#253
Open
mookid8000 wants to merge 2 commits intotaptapship:masterfrom
Open
Fix TypeError when streaming empty file#253mookid8000 wants to merge 2 commits intotaptapship:masterfrom
mookid8000 wants to merge 2 commits intotaptapship:masterfrom
Conversation
kaisermann
approved these changes
Sep 27, 2016
|
👍 |
silvenon
added a commit
to yeoman/generator-webapp
that referenced
this pull request
Nov 6, 2016
Fixes #584. Until taptapship/wiredep#253 is merged.
|
Merge, please? |
|
Please merge? |
|
I have the same problem, please merge this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When streaming an empty file, a TypeError is thrown as decribed in #219
This PR fixes that and provides a more helpful error if something is wrong with the argument passed to
Buffer