support rules as array for multiple file uploads#115
Open
simonbuehler wants to merge 3 commits intotanthammar:masterfrom
Open
support rules as array for multiple file uploads#115simonbuehler wants to merge 3 commits intotanthammar:masterfrom
simonbuehler wants to merge 3 commits intotanthammar:masterfrom
Conversation
allows rules for multiple files like ->rules(['files' => 'between:1,3', 'files.*' => 'required|max:1024'])
Contributor
Author
|
found a error when submitting , please don't merge |
Contributor
Author
|
works so far, rules can either be only per File Validation FileUpload::make('Uploads', 'files')
->multiple()
->rules('required|mimes:pdf,png,jpg,jpeg,gif|max:1024')or also for the Files Collection as well like setting it to be required or min/max number of files FileUpload::make('Uploads', 'files')
->multiple()
->rules(['files' => 'between:1,3', 'files.*' => ['required','mimes:pdf,png,jpg,jpeg,gif','max:1024']])
|
Owner
Contributor
Author
|
this would allow to use the old behaviour was to either show only the individual files error (for multiple set) or the single file error (multiple not set) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

allows rules for multiple files like
->rules(['files' => 'between:1,3', 'files.*' => 'required|max:1024'])so not only the individual file properties are validated but also e.g. the min/max number of uploaded files