Skip to content

Conversation

@tamada
Copy link
Owner

@tamada tamada commented Jan 25, 2026

No description provided.

@tamada tamada added this to the v1.0.0 milestone Jan 25, 2026
@tamada tamada requested a review from Copilot January 25, 2026 06:58
@tamada tamada self-assigned this Jan 25, 2026
@tamada tamada added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 25, 2026
@tamada tamada merged commit 6b94789 into main Jan 25, 2026
4 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates crate metadata/versioning and aligns the library crate with workspace-level license-file settings.

Changes:

  • Add license-file.workspace = true to lib/Cargo.toml
  • Bump workspace version to 0.8.13
  • Update README and container build args/badges to 0.8.13

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/Cargo.toml Inherit license-file from workspace package metadata
Cargo.toml Bump workspace package version to 0.8.13
README.md Update version and Docker badges to 0.8.13
Containerfile Update VERSION build args to 0.8.13

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 5 to 7
[workspace.package]
version = "0.8.12"
version = "0.8.13"
edition = "2024"
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title focuses on adding a license-file workspace configuration, but this PR also bumps the workspace version to 0.8.13 (and updates other files accordingly). Consider updating the PR title/description to reflect the version bump, or splitting the release/version updates into a separate PR to keep changes scoped.

Copilot uses AI. Check for mistakes.
Comment on lines 6 to 10
version.workspace = true
repository.workspace = true
authors.workspace = true
license-file.workspace = true
edition.workspace = true
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the lib crate is updated to inherit license-file from the workspace. The cli crate currently has neither license nor license-file set (and also doesn't inherit it), which can cause cargo publish/crates.io metadata checks to fail for totebag-cli. Consider adding license-file.workspace = true (or license.workspace = true) to cli/Cargo.toml as well to keep workspace crates consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants