Skip to content

Conversation

@tamada
Copy link
Owner

@tamada tamada commented Jan 25, 2026

No description provided.

@tamada tamada added this to the v1.0.0 milestone Jan 25, 2026
@tamada tamada requested a review from Copilot January 25, 2026 05:38
@tamada tamada self-assigned this Jan 25, 2026
@tamada tamada added the documentation Improvements or additions to documentation label Jan 25, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project version from 0.8.11 to 0.8.12 and makes structural changes to how the CLI binary is named and packaged.

Changes:

  • Version bumped from 0.8.11 to 0.8.12 across all configuration files
  • Removed the [[bin]] section from cli/Cargo.toml, causing the binary name to change from totebag to totebag-cli
  • Updated the publish workflow to handle the new binary name by introducing cliname variable and renaming the binary during packaging

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Updated workspace version to 0.8.12
cli/Cargo.toml Updated version reference and removed [[bin]] section that defined binary name
README.md Updated version badges from 0.8.11 to 0.8.12
Containerfile Updated VERSION argument to 0.8.12
.github/workflows/publish.yaml Added cliname variable and updated artifact naming to handle binary name change from totebag to totebag-cli

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 20 to 22
humansize = "2.1.3"
log = "0.4.25"
time = "0.3.37"
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the [[bin]] section will cause Cargo to name the binary after the package name totebag-cli instead of totebag. However, the Containerfile (line 22) still tries to copy /app/target/release/totebag. This will cause the Docker build to fail. Either the [[bin]] section should be kept, or the Containerfile needs to be updated to reference totebag-cli.

Copilot uses AI. Check for mistakes.
… and extractor modules

- Updated all instances of ToteError to Error in archiver implementations (ar, cab, cpio, lha, rar, sevenz, tar, zip).
- Modified error handling in extractor implementations (ar, cab, cpio, lha, rar, sevenz, tar) to use the new Error type.
- Enhanced the Error enum with Display implementation for better error messages.
- Added tests for error messages and created a new test archive file (test.tar.xz) for validation.
@tamada tamada merged commit 5a6109f into main Jan 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants