fix: correct YAML indentation in cln-plugin job step

[0xZaddyy]

Problem

The Link CLN step in the cln-plugin job was incorrectly indented. This resulted in an invalid workflow structure and potentially caused the job to fail or silently skip the CLN linking step.

Fix

• Moved the - name: Link CLN step to the correct top-level indentation within the steps list.
• Verified YAML structure is valid.

[mariocynicys]

Wow! I completely missed that while reviewing #268

At this point I am not really sure whether tests passed in that PR or not (I think they passed but this change was done in a rebase later so they were cancelled, I hope 🤞).
Thanks so much for spotting this. If you want, you can tackle the failing CI within this PR too.

[mariocynicys]

@0xZaddyy would be better if you leave rebasing to the end.
as rebasing removes the rebased commit and makes it harder to access the CI run history.
for now let's just append commits on top and rebase at the end before merging the PR.

[0xZaddyy]

@mariocynicys can you check this out now?

[mariocynicys]

happy to see the CI green again :)

[mariocynicys]

we already install poetry in the steps below. is it really needed at this step? we can then remove the step installing it below.

[0xZaddyy]

i couldn't access the previously installed poetry until i install it again, seems that is due to GitHub Actions steps not sharing the same shell state like a typical script.

[mariocynicys]

there shouldn't be a cache miss as this job depends on the cache job.
if the cache job hits a cache miss, it already re-prepares the cache.

[0xZaddyy]

Job was failing because lightning wasn't really found so i had to find a logic to handle miss if it happens since i can't join both Load CLN cache & Link CLN together.

[mariocynicys]

they are already causally joined together, see

rust-teos/.github/workflows/cln-plugin.yaml

Line 45 in 42db021

needs: cache-cln

also, checking the succeeding run, the echo line above didn't fire. so we can remove this whole block of code inside the if condition.

[mariocynicys]

i think we can omit "PATH"=$"PATH"

[mariocynicys]

or document why it's needed otherwise

[0xZaddyy]

we need "PATH"=$"PATH" because sudo resets the environment, including $PATH, which removes access to ~/.cargo/bin/ & ~/.local/bin/ and sudo is needed for permission.

[mariocynicys]

@0xZaddyy i think there is some trimming that could be done here. will check this late next week.

[0xZaddyy]

Alright, thank you!

[mariocynicys]

hey @0xZaddyy
i added some commits trying to trim down the workflow steps. could you please review them.
till now, the tests aren't passing (locally) due a timeout in starting lightning node. will be looking what the issue is.

[0xZaddyy]

hey @0xZaddyy i added some commits trying to trim down the workflow steps. could you please review them. till now, the tests aren't passing (locally) due a timeout in starting lightning node. will be looking what the issue is.

I’ll be digging into that now!

[mariocynicys]

till now, the tests aren't passing (locally) due a timeout in starting lightning node. will be looking what the issue is.

@0xZaddyy no need to dig. looks like this problem is from the local action runner i am using (https://github.com/nektos/act). it seems it doesn't share a lot of aspects with githubs CI and the two environments are vastly different.

[mariocynicys]

okie. i think this is looking good now.
@0xZaddyy could you please give it a review. i have written explanations in the commit messages.
but you should squash all of these into one commit before merging to not get much clutter into the master branch commit history.

[mariocynicys]

hey @0xZaddyy,
could you please squash these commits into one and sign it.

[0xZaddyy]

Hi @mariocynicys, apologies for the delay! I've squashed the commits as requested.

[mariocynicys]

Thanks @0xZaddyy

could you also sign the commit and write a brief description instead of git's aggregate commit description.
let me know if you need help writing the description.

[0xZaddyy]

Hi @mariocynicys i hope i've done it the right way

[mariocynicys]

Thanks for signing it.
One last thing missing:

and write a brief description instead of git's aggregate commit description.

this commit will make it to master and the commit description should makes sense so that people who use git-blame could make sense of what this commit did and the context behind it.

[0xZaddyy]

@mariocynicys does it look better now?

[mariocynicys]

Thanks for the fix.
LGTM!