-
Notifications
You must be signed in to change notification settings - Fork 66
Add nix flake #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix flake #266
Conversation
4971b1c to
6c4d671
Compare
6c4d671 to
d9b2b07
Compare
|
Thanks Will review this next week. I know nothing about nix though so we might wanna get another review from a nix expert. |
d9b2b07 to
24808b9
Compare
|
Ok great. I've been using this since last year but just updated nixpkgs to 25.05. |
Hello @mariocynicys, sorry for the late answer. I am not considering myself a nix expert :), but it looks good to me. It builds correctly and it seems it works as expected on my macos (nix-darwin): Could you please allow/approve the Github Actions to run for this PR, so we can check the CI tests are passing?
Thanks |
|
hey @JosephGoulden |
- Correct YAML indentation - Fix Poetry installation (no --user, avoids not found errors) - Remove unnecessary steps and sudo usage - Modularize CLN cache jobs - Run `poetry run make` concurrently to speed up build
24808b9 to
70ea8b5
Compare
mariocynicys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
LGTM. Thanks!
This is based off #262
I added a CI target to check the flake is correct. Also I added the features to tonic in teos-common as it does not currently compile with defaults.
I've got the tower and plugin both deployed based off this configuration and its working as expected.