Skip to content

Conversation

@notjustanyusername
Copy link

@notjustanyusername notjustanyusername commented Sep 15, 2024

This is based off #262

I added a CI target to check the flake is correct. Also I added the features to tonic in teos-common as it does not currently compile with defaults.

I've got the tower and plugin both deployed based off this configuration and its working as expected.

@mariocynicys
Copy link
Collaborator

Thanks

Will review this next week. I know nothing about nix though so we might wanna get another review from a nix expert.
@seberm could you give this a review please?

@notjustanyusername
Copy link
Author

Ok great. I've been using this since last year but just updated nixpkgs to 25.05.

@seberm
Copy link

seberm commented Oct 2, 2025

Ok great. I've been using this since last year but just updated nixpkgs to 25.05.

Hello @mariocynicys, sorry for the late answer. I am not considering myself a nix expert :), but it looks good to me.

It builds correctly and it seems it works as expected on my macos (nix-darwin):

❯ nix flake check                                                                                                                                                                                

❯ nix build

❯ ls -alh ./result/bin
total 18M
dr-xr-xr-x 4 root wheel  128 Jan  1  1970 ./
dr-xr-xr-x 3 root wheel   96 Jan  1  1970 ../
-r-xr-xr-x 1 root wheel 5.4M Jan  1  1970 teos-cli*
-r-xr-xr-x 1 root wheel  13M Jan  1  1970 teosd*

❯ ./result/bin/teos-cli -h
teos-cli 0.2.0
The Eye of Satoshi - CLI

USAGE:
    teos-cli [OPTIONS] <SUBCOMMAND>
....

❯ ./result/bin/teosd -h
teos 0.2.0
The Eye of Satoshi - Lightning watchtower

USAGE:
    teosd [FLAGS] [OPTIONS]
...

Could you please allow/approve the Github Actions to run for this PR, so we can check the CI tests are passing?

2 workflows awaiting approval

This workflow requires approval from a maintainer

Thanks

@mariocynicys
Copy link
Collaborator

hey @JosephGoulden
could you check the failing CI please.

0xZaddyy and others added 2 commits October 8, 2025 22:10
- Correct YAML indentation
- Fix Poetry installation (no --user, avoids not found errors)
- Remove unnecessary steps and sudo usage
- Modularize CLN cache jobs
- Run `poetry run make` concurrently to speed up build
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

LGTM. Thanks!

@mariocynicys mariocynicys merged commit be344ec into talaia-labs:master Oct 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants