Use distro provided rustup #505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I suppose I should try to handle Debian Bookworm since it doesn't have rustup packaged. |
This removes the need to download and run a shell script to set up the environment. The distro is instead trusted to provide a valid binary. Fedora has a package called "rustup", but it really is just the rustup-init binary [1]. Additionally handle the behavior changes for rustup 1.28.0, which removes implicit toolchain installation but adds support for installing from `rust-toolchain.toml`. [1]: https://src.fedoraproject.org/rpms/rustup Signed-off-by: Tim Crawford <[email protected]>
Member
Author
|
Done in #519. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to download and run a shell script to set up the environment. The distro is instead trusted to provide a valid binary.
Fedora has a package called "rustup", but it really is just the rustup-init binary [1].
Additionally handle the behavior changes for rustup 1.28.0, which removes implicit toolchain installation but adds support for installing from
rust-toolchain.toml.