fix(windows): use platform_binary_name to resolve sparkle-mcp.exe path#143
Merged
jackh726 merged 1 commit intosymposium-dev:mainfrom Feb 23, 2026
Merged
Conversation
cargo install was succeeding but the binary existence check was looking for `sparkle-mcp` instead of `sparkle-mcp.exe` on Windows, causing the mod to fail to load.
Contributor
|
That'd probably do it. Guess we don't have a windows CI runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, after successfully installing a cargo crate, the binary existence check was looking for
sparkle-mcpinstead ofsparkle-mcp.exe, causing the mod to fail to load with:Binary sparkle-mcp not found after installing sparkle-mcp@0.5.1This had a two-part effect:
This affected all cargo-distributed mods on Windows, including sparkle-mcp.
Fix
Added a platform_binary_name helper that appends .exe on Windows. Applied it to all three places where the binary path is constructed:
Testing
Manually verified on Windows x86-64 -- sparkle-mcp now loads correctly in the Symposium VSCode extension.