Skip to content

Sema: Exportability check protocols in non-library-evolution mode #85387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+293 −24
Open

Sema: Exportability check protocols in non-library-evolution mode #85387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2151d61
Sema: Support @_implementationOnly protocols
xymus Nov 6, 2025
bf5e5b6
Sema: Add more tests for class exportability checking in NLE
xymus Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/swift/AST/DeclAttr.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ SIMPLE_DECL_ATTR(_alwaysEmitIntoClient, AlwaysEmitIntoClient,
83)

SIMPLE_DECL_ATTR(_implementationOnly, ImplementationOnly,
OnImport | OnFunc | OnConstructor | OnVar | OnSubscript | OnStruct | OnClass | OnEnum,
OnImport | OnFunc | OnConstructor | OnVar | OnSubscript | OnNominalType,
UserInaccessible | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove | UnreachableInABIAttr,
84)

Expand Down
14 changes: 7 additions & 7 deletions lib/Sema/TypeCheckAccess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,13 +2163,13 @@ swift::getDisallowedOriginKind(const Decl *decl,
Feature::AssumeResilientCxxTypes))
return DisallowedOriginKind::FragileCxxAPI;

if (isa<StructDecl>(decl) || isa<EnumDecl>(decl)) {
if (decl->getASTContext().LangOpts.hasFeature(
Feature::CheckImplementationOnly) &&
decl->getAttrs().hasAttribute<ImplementationOnlyAttr>()) {
return DisallowedOriginKind::ImplementationOnlyMemoryLayout;
}
}
// Implementation-only memory layouts for non-library-evolution mode.
// Should we allow references to classes and protocols in non-embedded mode?
if (isa<NominalTypeDecl>(decl) &&
decl->getASTContext().LangOpts.hasFeature(
Feature::CheckImplementationOnly) &&
decl->getAttrs().hasAttribute<ImplementationOnlyAttr>())
return DisallowedOriginKind::ImplementationOnlyMemoryLayout;

// Report non-public import last as it can be ignored by the caller.
// See \c diagnoseValueDeclRefExportability.
Expand Down
Loading