Skip to content

ESP: fix build issues by introducing swift component#192

Open
Lapshin wants to merge 1 commit intoswiftlang:mainfrom
Lapshin:main
Open

ESP: fix build issues by introducing swift component#192
Lapshin wants to merge 1 commit intoswiftlang:mainfrom
Lapshin:main

Conversation

@Lapshin
Copy link

@Lapshin Lapshin commented Feb 3, 2026

@erhankur , this change fixes the issue with picolibc enabled that we discussed.

The root cause was adding CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES into the main target. It makes the include argument order unexpected.
When the inclusion was moved to a separate component, it respects includes from esp_libc that should be first.

IMO it's better to have swift in managed components. Could you take care of this?

Other observations:

  • BridgingHeader.h can be generated automatically (include all public headers from required components)
  • LED does not blink on my esp32c6 board. Even with the code before my changes

@erhankur
Copy link
Contributor

erhankur commented Feb 9, 2026

@Lapshin Thanks for the PR. Led blink issue is fixed in #191

@rauhul
Copy link
Member

rauhul commented Feb 11, 2026

I would prefer if this change moved the esp examples into an esp/ directory and the components was placed under there

@erhankur
Copy link
Contributor

@Lapshin Now we have one more example. esp32-uart-echo

@Lapshin
Copy link
Author

Lapshin commented Feb 12, 2026

depends on espressif/idf-extra-components#685

@Lapshin Lapshin force-pushed the main branch 2 times, most recently from c0caf5f to 564e1e8 Compare February 12, 2026 09:26
@erhankur
Copy link
Contributor

@Lapshin LGTM Nice cleanup. Tested all examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants