ESP: fix build issues by introducing swift component#192
Open
Lapshin wants to merge 1 commit intoswiftlang:mainfrom
Open
ESP: fix build issues by introducing swift component#192Lapshin wants to merge 1 commit intoswiftlang:mainfrom
Lapshin wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Member
|
I would prefer if this change moved the esp examples into an |
Contributor
|
@Lapshin Now we have one more example. |
Author
|
depends on espressif/idf-extra-components#685 |
erhankur
reviewed
Feb 12, 2026
c0caf5f to
564e1e8
Compare
Contributor
|
@Lapshin LGTM Nice cleanup. Tested all examples. |
erhankur
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@erhankur , this change fixes the issue with picolibc enabled that we discussed.
The root cause was adding
CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIESinto the main target. It makes the include argument order unexpected.When the inclusion was moved to a separate component, it respects includes from
esp_libcthat should be first.IMO it's better to have
swiftin managed components. Could you take care of this?Other observations:
BridgingHeader.hcan be generated automatically (include all public headers from required components)