Skip to content

Conversation

@Catalin-Roman
Copy link

@Catalin-Roman Catalin-Roman commented Jul 8, 2025

Resetting the "project_info" has an undesired side-effect: doesn't allow the patch of the SW360 project for fields like (example): "linkedProjects", "moderators".
image

@Catalin-Roman Catalin-Roman changed the title chore: don't reset project_info Revert breaking change (reset of project_info) Jul 8, 2025
@Catalin-Roman Catalin-Roman marked this pull request as ready for review July 8, 2025 10:07
@gernot-h
Copy link
Collaborator

gernot-h commented Jul 10, 2025

Thanks for your PR, @Catalin-Roman!

This line was seemingly added recently by @tngraf to fix some mypy warning, however, I can't reproduce the warning if removing the line.. Also resetting the value here looks indeed wrong, however I think @t-graf should have a 2nd look on it.

@Catalin-Roman, if you have time, would you be interested to add some test case to tests/test_create_project.py (using test_project_update as inspiration or just extending it to cover your use case) to assure we avoid such regressions in the future?

@Catalin-Roman
Copy link
Author

@gernot-h I will definitely add unit tests before the PR is accepted but before I do I would love to get the confirmation from @t-graf that the changes in this PR are ok and don't interfere with other use cases. Thanks!

@tngraf tngraf merged commit d9aaf4b into sw360:main Jul 11, 2025
6 checks passed
@tngraf
Copy link
Collaborator

tngraf commented Jul 11, 2025

@Catalin-Roman Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants