fix(bom map): use PURL from SW360 in output BOM #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapBom::update_bom_item() relied on an outdated (?) field (`RepositoryId`) in the internal BOM data structure, which was not populated for releases retrieved from SW360, so the PURL from the input BOM was not replaced by SW360 data. Now rely on the result from get_purl_from_match() which correctly looks up the purl in RepositoryId as well as in `ExteralIds`. Fixes #158
I accidentally added a doscstring change in Commit efaa5a5 from a planned change which will likely be done differently. Remove it.
This old logic was already removed in CaPyCli 2.8.1, commit 90b1b7b.
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 7, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 9, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 9, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 9, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 9, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 11, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 23, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 23, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 23, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 23, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
gernot-h
added a commit
to sw360/capywfa
that referenced
this pull request
Jul 29, 2025
Newer CaPyCli versions update purl on mapping, see See sw360/capycli#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #158 and adds a corresponding test case (or better slightly modifies an existing test case to test this 😉).
Additionally, this PR contains two commits with unrelated doc fixes I stumbled over when looking into the PURL code. Let me know if I should move them to a separate PR!