drop Python 3.8 and vcr support so we can update urllib3 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to update urllib3 to 2.5 to fix CVE-2025-50181 and -50182. As it requires Python 3.9, we drop support for Python 3.8. Unfortunately, vcr would also partly block the urllib3 update due to kevin1024/vcrpy#926. We anyhow don't use it anymore, so let's remove it. This requires some refactoring moving general infrastructure from the VCR base to better places.
Collaborator
Author
|
As far as I can see, the mypy failures are in main already, not caused by my changes. |
Collaborator
Author
|
I think "requests" needs to be updated, too, which I leave up to you for now, @tngraf as I don't have time to also look into this at the moment. |
Collaborator
|
Thanks, @gernot-h, I fixed all style issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update urllib3 to 2.5 to fix CVE-2025-50181 and -50182. As it requires Python 3.9, we drop support for Python 3.8.
Unfortunately, vcr would also partly block the urllib3 update due to kevin1024/vcrpy#926. We anyhow don't use it anymore, so let's remove it. This requires some refactoring moving general infrastructure from the VCR base to better places.