-
Notifications
You must be signed in to change notification settings - Fork 13
PURL qualifier-based search #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75a5b6f to
32f0448
Compare
2000045 to
f03cf04
Compare
956eccd to
2fe0b65
Compare
2fe0b65 to
454b41d
Compare
454b41d to
44ced97
Compare
5bf491a to
19382df
Compare
49ec3bd to
91c0628
Compare
|
This is mostly ready, but unconditionally changing the mapping behaviour. I agreed with @tngraf to keep current mapping behaviour as default and add commandline switches for the new mapping algorithms. Currently, we have the following switches changing behaviour of "bom map":
To not end up with numerous cmdline parameters in "bom map", I agreed with @tngraf to deprecate |
91c0628 to
3fad13e
Compare
The previous code used to abort the mapping on the first good match. So better or equal other matches could stay unnoticed. Also, the mapping result may have depended on the order in which releases were found. bom map --matchmode full-search allows to check all releases for possible matches and thus assure that the mapping results are deterministic and contain best matches. To get the logic right, we also need to do the checks in the order of MapResult priorities.
This allows to return multiple PURL results. This is needed to implement PURL fallback mapping with qualifiers (#139).
This adds support for PURLs with qualifiers, introducing the following semantics: Only qualifiers specified in the BOM are compared. If entries are found where all of them match, only those are returned.
3fad13e to
8153bbd
Compare
|
@t-graf, the PR is finally ready for review and probably merging. This basically contains three changes:
I suggest to review the changes commit by commit, and if you want we can also split this into two PRs, just let me know! |
Qualifier code from sw360/capycli#144 has been merged.
Qualifier code from sw360/capycli#144 has been merged.
Qualifier code from sw360/capycli#144 has been merged.
Contains following changes/features:
Fixes #139
Fixes #150