Conversation
1. IRequest.cs: - Removed IUriBuilder Uri(string uri) - Added IRequest WithUri(string uri) for clarity 2. BaseRequest.cs: - Made WithUri(string) public (implementing IRequest) - Removed Uri(string) override 3. UriBuilder.cs: Updated Back() to call _request.WithUri(Build()) 4. RequestTests.cs: Updated tests to use WithUri instead of Uri(string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
This pull request refactors how the base URI is set on requests by replacing the
Uri(string uri)method with a newWithUri(string uri)method across the codebase. This change clarifies intent and improves the API's expressiveness. The update is reflected in the interface, implementation, and related usage, and is accompanied by new tests to verify the behavior.API changes:
Uri(string uri)method withWithUri(string uri)in theIRequestinterface, including updated XML documentation to clarify its purpose.BaseRequestto provide the newWithUri(string uri)method, replacing the old method.Usage updates:
UriBuilderso that theBack()method now usesWithUri(Build())instead of the removedUri(string uri).Testing improvements:
WithUrireturns a new request, and another to verify that further URI building afterWithUriworks as expected.