Conversation
Make JsonResponse and XmlResponse override the AssertStatus method to return the correct type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
This pull request adds support for asserting HTTP status codes directly on
JsonResponseandXmlResponseobjects, enabling more fluent method chaining in tests and response handling. It introduces newAssertStatusmethods for both response types and adds corresponding unit tests to verify correct behavior and chaining.Enhancements to response status assertion:
AssertStatus(int expectedStatus)method to theJsonResponseclass, allowing assertions on HTTP status codes and enabling method chaining. (src/SergeiM.Http/Response/JsonResponse.cs)AssertStatus(int expectedStatus)method to theXmlResponseclass, enabling status code assertions and fluent chaining. (src/SergeiM.Http/Response/XmlResponse.cs)Unit test improvements:
JsonResponse.AssertStatusto verify correct status assertion and method chaining. (src/SergeiM.Http.Tests/JsonResponseTests.cs)XmlResponse.AssertStatusto confirm status assertion and chaining functionality. (src/SergeiM.Http.Tests/XmlResponseTests.cs)