docs: fix Result.map example in README.md#664
Open
rivea0 wants to merge 1 commit intosupermacro:masterfrom
Open
docs: fix Result.map example in README.md#664rivea0 wants to merge 1 commit intosupermacro:masterfrom
Result.map example in README.md#664rivea0 wants to merge 1 commit intosupermacro:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631.
With the previous example:
parseIntgets the indices as its second parameter for the base.Providing a callback where we pass the item gets rid of the issue:
The base now defaults to 10.
To be even more explicit, we could have also added the second argument to
parseIntas well, and maybe a comment to explain it:I think the first option is sufficient, but I can make changes to the PR if needed.