docs: clarify setSession network behavior in doc comment#1332
Merged
grdsdev merged 2 commits intoguilherme/sdk-784-featauth-add-setsession-support-for-both-access_token-andfrom Mar 25, 2026
Conversation
7 tasks
Co-authored-by: grdsdev <5923044+grdsdev@users.noreply.github.com> Agent-Logs-Url: https://github.com/supabase/supabase-flutter/sessions/db643f38-73ec-4b87-92e3-9d995d319a73
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on accessToken parameter in setSession() implementation
docs: clarify setSession network behavior in doc comment
Mar 25, 2026
grdsdev
approved these changes
Mar 25, 2026
grdsdev
merged commit 8946afa
into
guilherme/sdk-784-featauth-add-setsession-support-for-both-access_token-and
grdsdev
added a commit
that referenced
this pull request
Mar 30, 2026
* Initial plan * docs: clarify setSession skips /token refresh but still calls /user Co-authored-by: grdsdev <5923044+grdsdev@users.noreply.github.com> Agent-Logs-Url: https://github.com/supabase/supabase-flutter/sessions/db643f38-73ec-4b87-92e3-9d995d319a73 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: grdsdev <5923044+grdsdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setSession()doc comment incorrectly stated the session was restored "without a network round-trip" when a validaccessTokenis provided — it still calls/userto populate the user object; only the/tokenrefresh call is skipped.Changes
gotrue_client.dart: Rewrote thesetSession()doc comment to accurately state it skips the/tokenrefresh round-trip but still issues a/userrequest to populate the session's user object.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.