feat(pg_repack): use default nixos extension test

[jfroche]

Lower the maintenance by reusing the default extension test.

Summary by CodeRabbit

• New Features

  • pg_repack extension is now included in the supported extensions.

• Chores

  • Test harness improved with per-extension flags to selectively run upgrade and regression checks.
  • pg_repack tests consolidated into the shared test flow for consistent upgrade and regression validation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The test harness is updated to consolidate pg_repack testing: two flags (support_upgrade, run_pg_regress) gate test blocks and metadata; the standalone pg_repack.nix test file was removed and pg_repack was added to the exported extension list.

Changes

Cohort / File(s)	Change Summary
Test Harness (flags & gating) nix/ext/tests/default.nix	Added support_upgrade and run_pg_regress per-extension flags; exposed support_upgrade in test metadata; wrapped pg_regress, upgrade checks, last-version installation, and extension-version switching blocks behind run_pg_regress; tightened ext_has_background_worker to require support_upgrade.
Extension list export nix/ext/tests/default.nix	Added pg_repack to the exported/public extension list in the extTest factory.
Removed standalone test nix/ext/tests/pg_repack.nix	Deleted the separate pg_repack runTest-based file that defined an isolated PostgreSQL environment, multi-version upgrade workflow, and migration/test scripts.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Harness as "Test Harness\n(nix/ext/tests/default.nix)"
participant Meta as "Test Metadata"
participant PG15 as "Postgres 15 instance"
participant PG17 as "Postgres 17 instance"
participant PgReg as "pg_regress runner"
participant Ext as "Extension (pg_repack)"

rect rgba(200,200,255,0.5)
Harness->>Meta: emit per-extension flags\n(support_upgrade, run_pg_regress)
Meta-->>Harness: flags for extension
end

rect rgba(200,255,200,0.5)
Harness->>Ext: select extension (pg_repack)
alt run_pg_regress = true
Harness->>PgReg: run pg_regress tests\nagainst PG15/PG17
PgReg->>PG15: execute tests
PgReg->>PG17: execute tests
else run_pg_regress = false
Harness->>Ext: skip pg_regress blocks
end
end

rect rgba(255,200,200,0.5)
alt support_upgrade = true
Harness->>PG15: perform upgrade workflow -> PG17
PG15-->>PG17: upgrade/migrate data
else support_upgrade = false
Harness->>Ext: skip upgrade-related checks
end
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Suggested reviewers

• samrose
• LGUG2Z

Poem

🐰 In harness halls the tests converge,
Flags wave softly, flows emerge,
pg_repack hops into line,
One file gone, one flag to shine,
Rabbit cheers—checks pass by design! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description 'Lower the maintenance by reusing the default extension test' is very brief but conveys the intent. However, it lacks detail about what was changed, why, and any implementation notes expected from the template.	Expand the description to clarify which files were modified, what the default test harness includes, and any behavioral differences in testing pg_repack after this change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat(pg_repack): use default nixos extension test' clearly and specifically summarizes the main change - consolidating pg_repack to use the default test harness instead of a custom isolated test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@nix/ext/tests/default.nix`:
- Around line 180-182: The test calls to check_upgrade_path are unconditional
even when support_upgrade is False; update the test to guard these calls by
checking the instance attribute before invoking them (e.g., wrap calls to
check_upgrade_path(...) in if self.support_upgrade: or if support_upgrade: where
appropriate), or alternatively add an early return at the start of the
check_upgrade_path method that returns immediately when self.support_upgrade is
False; locate the method check_upgrade_path and the boolean support_upgrade
declaration to implement the chosen guard so the upgrade-path test is skipped
when support_upgrade is disabled.