refactor(runtime): make duplex_stream_rx optional in RunOptions#680
Open
jaehafe wants to merge 1 commit intosupabase:mainfrom
Open
refactor(runtime): make duplex_stream_rx optional in RunOptions#680jaehafe wants to merge 1 commit intosupabase:mainfrom
duplex_stream_rx optional in RunOptions#680jaehafe wants to merge 1 commit intosupabase:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor — resolves a TODO left by @nyannyacha
What is the current behavior?
RunOptions.duplex_stream_rxis required, so even workers that don't useDeno.serve()(e.g. pure computation, memory tests) must create a dummympsc::unbounded_channeljust to satisfyRunOptionsBuilder::build().What is the new behavior?
duplex_stream_rx is now Option in RunOptions. Workers that don't need networking can omit it entirely.
Changes
RunOptions.duplex_stream_rx:UnboundedReceiver→Option<UnboundedReceiver>RunOptionsBuilder::build(): removed forced unwrap, passesOptionthroughDenoRuntime::run(): conditionally puts receiver intoOpStateviaif let Someop_net_accept: error message improved from"already used"to"not available"No behavioral change for production callers —
managed.rsanduser.rsalwaysprovide a receiver.
op_net_acceptalready handlesNoneviatry_take.Additional context
All related tests pass (9/9): cargo test --package base