Skip to content

Print version & Add more sql time metrics #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewiszlw merged 2 commits into from
Dec 11, 2025
Merged

Print version & Add more sql time metrics #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2efa4ad
Print version & Add more sql time metrics
lewiszlw Dec 11, 2025
83af2cd
rename data to rows
lewiszlw Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ impl Session {
.map_err(|err| ArrowError::IpcError(err.to_string()))?;

if is_repl {
println!("Welcome to Arrow CLI.");
println!("Welcome to Arrow CLI v{}.", env!("CARGO_PKG_VERSION"));
println!("Connecting to {} as user {}.", endpoint.uri(), user);
println!();
}
let mut client = FlightSqlServiceClient::new(channel);
let _token = client.handshake(user, password).await.unwrap();
let _token = client.handshake(user, password).await?;

let prompt = format!("{} :) ", endpoint.uri().host().unwrap());
Ok(Self {
Expand Down Expand Up @@ -124,7 +124,7 @@ impl Session {
let start = Instant::now();
let mut stmt = self.client.prepare(query.to_string(), None).await?;
let flight_info = stmt.execute().await?;
let sql_exec_duration = start.elapsed();
let ticket_recv_duration = start.elapsed();
let mut batches: Vec<RecordBatch> = Vec::new();

let mut handles = Vec::with_capacity(flight_info.endpoint.len());
Expand All @@ -147,6 +147,7 @@ impl Session {
for handle in handles {
batches.extend(handle.await.unwrap()?);
}
let rows_recv_duration = start.elapsed();

if is_repl {
let res = pretty_format_batches(batches.as_slice())?;
Expand All @@ -156,9 +157,10 @@ impl Session {

let rows: usize = batches.iter().map(|b| b.num_rows()).sum();
println!(
"{} rows in set ({:.3} sec)",
"{} rows in set (tickets received in {:.3} sec, rows received in {:.3} sec)",
rows,
sql_exec_duration.as_secs_f64()
ticket_recv_duration.as_secs_f64(),
rows_recv_duration.as_secs_f64(),
);
println!();
} else {
Expand Down