Skip to content

Conversation

@glenntfung
Copy link
Contributor

My plan is to wait until Basics, Numbers, Strings are translated to mark this PR as completed.

@vercel
Copy link

vercel bot commented Nov 5, 2025

@glenntfung is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
learn-javascript Ready Ready Preview Comment Dec 1, 2025 0:26am

@sumn2u
Copy link
Owner

sumn2u commented Nov 22, 2025

@glenntfung Thanks for this draft PR. Quick question, are you also going to work on the Basics, Numbers and Strings?

@glenntfung
Copy link
Contributor Author

@glenntfung Thanks for this draft PR. Quick question, are you also going to work on the Basics, Numbers and Strings?

Yes, I am actually working on it and hopefully it will be done before thanksgiving.

@sumn2u
Copy link
Owner

sumn2u commented Nov 23, 2025

@glenntfung Thanks for this draft PR. Quick question, are you also going to work on the Basics, Numbers and Strings?

Yes, I am actually working on it and hopefully it will be done before thanksgiving.

Looking forward to it.

It says single quote in the comment, so the example should be single quote
@glenntfung glenntfung marked this pull request as ready for review December 1, 2025 06:01
@glenntfung
Copy link
Contributor Author

These three parts are finished. I rebased so the commit date of the first commit changed :(

I also fixed a typo that could cause confusion in a separate commit in the English version I spotted.

Known issues: links to untranslated files.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Chinese translations for three fundamental sections of the JavaScript documentation: Basics (Chapter 2), Numbers (Chapter 3), and Strings (Chapter 4). The PR also includes a minor fix to the English strings documentation to correct quote style consistency.

Key Changes:

  • Added complete Chinese translations for 15 new documentation files covering core JavaScript concepts
  • Fixed quote consistency in English strings/create.md (changed double quotes to single quotes in example)
  • Provided comprehensive coverage of variables, types, operators, strings methods, and number operations in Chinese

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
en/strings/create.md Fixed quote style consistency - changed double quotes to single quotes in single-quote example
cn/basics/README.md Added Chinese translation for Basics chapter introduction
cn/basics/comments.md Added Chinese translation covering single-line and multi-line comment syntax
cn/basics/equality.md Added Chinese translation explaining == vs === operators (contains variable naming issue)
cn/basics/types.md Added Chinese translation covering JavaScript data types and type checking
cn/basics/variables.md Added Chinese translation explaining variable declaration with var, let, and const
cn/numbers/README.md Added Chinese translation for Numbers chapter introduction
cn/numbers/math.md Added Chinese translation for Math object methods and properties (contains typo)
cn/numbers/operators.md Added Chinese translation for arithmetic, assignment, comparison, logical, ternary, bitwise, and typeof operators (contains multiple operator typos and duplicate heading)
cn/numbers/advanced.md Added Chinese translation for advanced operators including precedence, modulo, exponentiation, increment/decrement (contains syntax error)
cn/strings/README.md Added Chinese translation for Strings chapter introduction with method reference table
cn/strings/charAt.md Added Chinese translation for charAt() method (contains incorrect output example)
cn/strings/concat.md Added Chinese translation for string concatenation methods
cn/strings/create.md Added Chinese translation for string creation including literals, constructors, and template literals
cn/strings/length.md Added Chinese translation for string length property (contains backtick inconsistency)
cn/strings/replace.md Added Chinese translation for replace() method with regex examples (contains backtick inconsistency)
cn/strings/split.md Added Chinese translation for split() method with various examples
cn/strings/substring.md Added Chinese translation for substring() method (contains duplicate heading and incorrect output example)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Repository owner deleted a comment from Copilot AI Dec 1, 2025
Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sumn2u sumn2u merged commit 9d6719b into sumn2u:main Dec 1, 2025
3 checks passed
@sumn2u
Copy link
Owner

sumn2u commented Dec 12, 2025

@glenntfung The translated content is now displayed on the webpage. Thank you for the translation.

Screenshot 2025-12-12 at 11 33 44 AM

@glenntfung
Copy link
Contributor Author

glenntfung commented Dec 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants