-
Notifications
You must be signed in to change notification settings - Fork 185
Translation[CN]: Basics, Numbers, Strings #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@glenntfung is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@glenntfung Thanks for this draft PR. Quick question, are you also going to work on the |
Yes, I am actually working on it and hopefully it will be done before thanksgiving. |
Looking forward to it. |
It says single quote in the comment, so the example should be single quote
|
These three parts are finished. I rebased so the commit date of the first commit changed :( I also fixed a typo that could cause confusion in a separate commit in the English version I spotted. Known issues: links to untranslated files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Chinese translations for three fundamental sections of the JavaScript documentation: Basics (Chapter 2), Numbers (Chapter 3), and Strings (Chapter 4). The PR also includes a minor fix to the English strings documentation to correct quote style consistency.
Key Changes:
- Added complete Chinese translations for 15 new documentation files covering core JavaScript concepts
- Fixed quote consistency in English strings/create.md (changed double quotes to single quotes in example)
- Provided comprehensive coverage of variables, types, operators, strings methods, and number operations in Chinese
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| en/strings/create.md | Fixed quote style consistency - changed double quotes to single quotes in single-quote example |
| cn/basics/README.md | Added Chinese translation for Basics chapter introduction |
| cn/basics/comments.md | Added Chinese translation covering single-line and multi-line comment syntax |
| cn/basics/equality.md | Added Chinese translation explaining == vs === operators (contains variable naming issue) |
| cn/basics/types.md | Added Chinese translation covering JavaScript data types and type checking |
| cn/basics/variables.md | Added Chinese translation explaining variable declaration with var, let, and const |
| cn/numbers/README.md | Added Chinese translation for Numbers chapter introduction |
| cn/numbers/math.md | Added Chinese translation for Math object methods and properties (contains typo) |
| cn/numbers/operators.md | Added Chinese translation for arithmetic, assignment, comparison, logical, ternary, bitwise, and typeof operators (contains multiple operator typos and duplicate heading) |
| cn/numbers/advanced.md | Added Chinese translation for advanced operators including precedence, modulo, exponentiation, increment/decrement (contains syntax error) |
| cn/strings/README.md | Added Chinese translation for Strings chapter introduction with method reference table |
| cn/strings/charAt.md | Added Chinese translation for charAt() method (contains incorrect output example) |
| cn/strings/concat.md | Added Chinese translation for string concatenation methods |
| cn/strings/create.md | Added Chinese translation for string creation including literals, constructors, and template literals |
| cn/strings/length.md | Added Chinese translation for string length property (contains backtick inconsistency) |
| cn/strings/replace.md | Added Chinese translation for replace() method with regex examples (contains backtick inconsistency) |
| cn/strings/split.md | Added Chinese translation for split() method with various examples |
| cn/strings/substring.md | Added Chinese translation for substring() method (contains duplicate heading and incorrect output example) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
sumn2u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@glenntfung The translated content is now displayed on the webpage. Thank you for the translation.
|
|
Amazing, thanks for letting me know! I will try to work on more of them after the winter recess.
… On Dec 12, 2025, at 10:40 AM, Suman Kunwar ***@***.***> wrote:
sumn2u
left a comment
(sumn2u/learn-javascript#363)
<#363 (comment)>
@glenntfung <https://github.com/glenntfung> The translated content is now displayed on the webpage. Thank you for the translation.
Screenshot.2025-12-12.at.11.33.44.AM.png (view on web) <https://github.com/user-attachments/assets/66c65a40-609b-4bfb-9ef2-8f10e3e52cc4>
—
Reply to this email directly, view it on GitHub <#363 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4C7A2DXPX2WG4MMDRXJ3ED4BLVYZAVCNFSM6AAAAACLFPY7TKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBXGMYTMMZZGI>.
You are receiving this because you were mentioned.
|

My plan is to wait until Basics, Numbers, Strings are translated to mark this PR as completed.