Added a simple Stopwatch App using HTML, CSS, and JavaScript (#324) #334
Conversation
|
@ArshadShaik07 is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a stopwatch web application built with HTML, CSS, and JavaScript, featuring start, stop, and reset functionality with accurate time tracking. However, the PR includes files for both a weather app and stopwatch app, which appears inconsistent with the stated purpose.
- Added complete stopwatch application with time display and control buttons
- Included weather app files that seem unrelated to the stopwatch functionality
- Implemented responsive design and clean UI styling
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/Stopwatch-app/index.html | HTML structure for stopwatch with display and control buttons |
| examples/Stopwatch-app/styles.css | CSS styling for responsive stopwatch interface |
| examples/Stopwatch-app/script.js | JavaScript logic for stopwatch timing functionality |
| examples/Weather-app/index.html | Weather app HTML (unrelated to stopwatch PR) |
| examples/Weather-app/styles.css | Weather app styling (unrelated to stopwatch PR) |
| examples/Weather-app/script.js | Weather app JavaScript (unrelated to stopwatch PR) |
Comments suppressed due to low confidence (1)
examples/Weather-app/script.js:1
- Code sets innerHTML values that are immediately overwritten by subsequent textContent assignments, making the initial innerHTML assignments unnecessary.
const city = document.querySelector(".city-name-input");
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (res.status === 404) { | ||
| throw Error("City not found"); | ||
| } else if (res.status === 401) { | ||
| throw Error("Access denied.Check your api key "); |
There was a problem hiding this comment.
Missing space after period in error message.
| throw Error("Access denied.Check your api key "); | |
| throw Error("Access denied. Check your api key "); |
| function stop() { | ||
| if (running) { | ||
| clearInterval(timerInterval); | ||
| elapsedTime = Date.now() - startTime; |
There was a problem hiding this comment.
The elapsedTime calculation in stop() function is incorrect. It should preserve the accumulated elapsed time, not recalculate from startTime.
| elapsedTime = Date.now() - startTime; | |
| elapsedTime += Date.now() - startTime; |
|
@ArshadShaik07 Nice work. When you have time can you look into the above suggestions? |
|
Sure! I checked all the suggestions, but they don’t seem correct for this code. Everything works fine as it is. Still, let me know if there’s anything specific you want me to change. |
2 participants
Fixes #324
This pull request adds a stopwatch web app built using HTML, CSS, and JavaScript.
✅ Features:
This project was created as part of Hacktoberfest.
