Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 13, 2026

The snctl v1.6.0 formula update introduced Sorbet linting violations that caused build failures.

Changes:

  • Refactored formula to use idiomatic on_intel/on_arm blocks instead of if Hardware::CPU conditionals
  • Consolidated four duplicate def install methods (defined inside conditional blocks) into a single method outside blocks

Before:

on_macos do
  if Hardware::CPU.intel?
    url "..."
    def install
      bin.install "snctl"
    end
  end
end

After:

on_macos do
  on_intel do
    url "..."
  end
end

def install
  bin.install "snctl"
end

This resolves all 4 Sorbet/BlockMethodDefinition offenses flagged by brew style.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update snctl to version 1.6.0 Fix Sorbet linting errors and CI git configuration in snctl formula Jan 13, 2026
Copilot AI requested a review from freeznet January 13, 2026 02:27
@freeznet
Copy link
Member

@copilot the ci get passed, and now lets revert the chages of ‎.github/workflows/ci.yml‎ to make this PR only fix the ‎Formula/snctl.rb‎ issue

Copy link
Contributor Author

Copilot AI commented Jan 13, 2026

@copilot the ci get passed, and now lets revert the chages of ‎.github/workflows/ci.yml‎ to make this PR only fix the ‎Formula/snctl.rb‎ issue

Reverted in ce1134e. The PR now only contains the snctl formula fix, with CI workflow changes removed.

Copilot AI changed the title Fix Sorbet linting errors and CI git configuration in snctl formula Fix Sorbet linting errors in snctl formula Jan 13, 2026
@freeznet freeznet marked this pull request as ready for review January 13, 2026 03:13
@freeznet freeznet requested review from a team and zymap as code owners January 13, 2026 03:13
@freeznet freeznet merged commit 3667f0e into snctl/v1.6.0 Jan 13, 2026
@freeznet freeznet deleted the copilot/sub-pr-119 branch January 13, 2026 03:13
freeznet added a commit that referenced this pull request Jan 13, 2026
* [create-pull-request] automated change

* Fix Sorbet linting errors in snctl formula (#120)

* Initial plan

* Fix CI failure and linting errors in snctl formula

Co-authored-by: freeznet <[email protected]>

* Revert CI workflow changes, keep only snctl formula fix

Co-authored-by: freeznet <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: freeznet <[email protected]>

---------

Co-authored-by: freeznet <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: freeznet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants