sv1: remove third-party hex crate dependency #2054
Merged
+23
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8144225309
changed the title
plebhash
approved these changes
Jan 23, 2026
Member
|
LGTM @8144225309 can you please rebase against (ideally an actual rebase, not merging with an extra commit) |
Replace hex crate with bitcoin_hashes::hex traits (FromHex, ToHex) which are already available via the existing bitcoin_hashes dependency. This removes a 3rd-party dependency without adding new code to maintain.
8144225309
force-pushed
the
remove-hex-crate-sv1
branch
from
59dada5 to
a2643e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
hexcrate withbitcoin_hashes::hex::{FromHex, ToHex}traitsalready available through existing dependency.
hex::decode()→Vec::<u8>::from_hex()hex::encode()→.to_hex()bitcoin_hashes::ErrorCloses #375