Add framing benches #2051
Open
Add framing benches #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shourya742
force-pushed
the
2026-01-19-add-benches-for-framing
branch
3 times, most recently
from
479bbcc to
224f312
Compare
| /// | ||
| /// The calculated length includes the full payload length and any additional space required | ||
| /// for the MACs. | ||
| #[allow(clippy::manual_div_ceil)] |
Collaborator
There was a problem hiding this comment.
Why not use div_ceil?
Collaborator
Author
There was a problem hiding this comment.
on my machine div_ceil was quite slow compared to current version.
Shourya742
force-pushed
the
2026-01-19-add-benches-for-framing
branch
from
224f312 to
c424245
Compare
Shourya742
force-pushed
the
2026-01-19-add-benches-for-framing
branch
from
c424245 to
afc99d7
Compare
|
|
||
| for &size in PAYLOAD_SIZES { | ||
| group.bench_with_input(BenchmarkId::from_parameter(size), &size, |b, _| { | ||
| b.iter(|| Sv2Frame::<Vec<u8>, _>::from_bytes(black_box(payload(size))).unwrap()) |
Collaborator
There was a problem hiding this comment.
aren't we also computing the time for the payload() to create the vec? Shoudn't we compute the payload()outside of the iter()?
|
|
||
| fn tester(size: usize) -> Tester { | ||
| Tester { | ||
| _a: vec![2u8; size], |
Collaborator
There was a problem hiding this comment.
shoudn't this be using payload()?
Suggested change
| _a: vec![2u8; size], | |
| _a: payload(size), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2059