replace deprecated java.net.URL usage with java.net.URI #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated in Java 20. Migrate URL parsing to backward compatible URI.
stklcode
changed the title
stklcode
force-pushed
the
refactor/java-url
branch
from
9504899 to
dad3502
Compare
We can just pass the environment variable to other pre-existing methods instead of parsing the URL twice. This also fixes URLs without explicit ports where we should not store "-1" in this case.
stklcode
force-pushed
the
refactor/java-url
branch
from
eb0a12e to
ee2543e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in Java 20. Migrate URL parsing to backward compatible URI.