deprecate default methods to read specific database credentials #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
changed the title
The interface has some methods to read database credentials from specific mountpoints like "mysql". While ann database mounts share the same credential endpoints, the mount point itself can have any name. Let's clean up some methods of low benefit and deprecate the convenience methods. Trivial replacement is `getDbCredentials()` with explicit mount point, if it's actually mounted on that path.
stklcode
force-pushed
the
deprecate/read-db
branch
from
6474727 to
d329af2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface has some methods to read database credentials from specific mountpoints like "mysql". While ann database mounts share the same credential endpoints, the mount point itself can have any name. Let's clean up some methods of low benefit and deprecate the convenience methods.
Trivial replacement is
getDbCredentials()with explicit mount point, if it's actually mounted on that path.