fix(ContactBook): clear open menu on add, muxed identicon base address, federation resolution on Enter#2658
Merged
piyalbasu merged 2 commits intofeature/contact-book-uifrom Mar 19, 2026
Conversation
…lution on Enter Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement contact book UI feature
fix(ContactBook): clear open menu on add, muxed identicon base address, federation resolution on Enter
Mar 19, 2026
piyalbasu
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three behavioral bugs in the Contact Book UI: open context menu not dismissed when add modal opens, muxed address identicons using M-address instead of underlying G-address, and federation addresses not resolved when submitting via Enter without blurring the field.
Changes
handleAddContactclears open menu — callssetOpenMenuAddress(null)before opening the add modal, consistent withhandleEditContactMuxed identicon normalization —
IdenticonImgnow receivesgetBaseAccount(address) ?? addressfor muxed contacts instead of the raw M-address:Federation resolution decoupled from blur — removed the
hasAddressBlurred/activeFieldgate in theis-not-federation-failureYup test. Resolution now triggers whenever the value differs fromlastResolvedInput, covering Enter-to-submit without blur. The existingAbortControllerhandles per-keystroke cancellation.Test mock updated — added
isMuxedAccountandgetBaseAccountto thehelpers/stellarjest mock inContactBook.test.tsx📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.