Skip to content

fix(ContactBook): clear open menu on add, muxed identicon base address, federation resolution on Enter#2658

Merged
piyalbasu merged 2 commits intofeature/contact-book-uifrom
copilot/sub-pr-2612
Mar 19, 2026
Merged

fix(ContactBook): clear open menu on add, muxed identicon base address, federation resolution on Enter#2658
piyalbasu merged 2 commits intofeature/contact-book-uifrom
copilot/sub-pr-2612

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Three behavioral bugs in the Contact Book UI: open context menu not dismissed when add modal opens, muxed address identicons using M-address instead of underlying G-address, and federation addresses not resolved when submitting via Enter without blurring the field.

Changes

  • handleAddContact clears open menu — calls setOpenMenuAddress(null) before opening the add modal, consistent with handleEditContact

  • Muxed identicon normalizationIdenticonImg now receives getBaseAccount(address) ?? address for muxed contacts instead of the raw M-address:

    publicKey={
      data.resolvedAddress ||
      (isMuxedAccount(address) ? (getBaseAccount(address) ?? address) : address)
    }
  • Federation resolution decoupled from blur — removed the hasAddressBlurred/activeField gate in the is-not-federation-failure Yup test. Resolution now triggers whenever the value differs from lastResolvedInput, covering Enter-to-submit without blur. The existing AbortController handles per-keystroke cancellation.

  • Test mock updated — added isMuxedAccount and getBaseAccount to the helpers/stellar jest mock in ContactBook.test.tsx


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…lution on Enter

Co-authored-by: piyalbasu <6789586+piyalbasu@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement contact book UI feature fix(ContactBook): clear open menu on add, muxed identicon base address, federation resolution on Enter Mar 19, 2026
Copilot AI requested a review from piyalbasu March 19, 2026 19:30
@piyalbasu piyalbasu marked this pull request as ready for review March 19, 2026 20:24
@piyalbasu piyalbasu merged commit 088f693 into feature/contact-book-ui Mar 19, 2026
2 checks passed
@piyalbasu piyalbasu deleted the copilot/sub-pr-2612 branch March 19, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants