Open
Conversation
leofelix077
added
wip
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the resource fee display on the send flow by adding a detailed fee breakdown pane to the review transaction screen, showing inclusion fee and resource fee separately for Soroban transactions.
Changes:
- Added a new "Fee breakdown" pane in
ReviewTransactionshowing inclusion fee, resource fee, and total fee with contextual descriptions for classic vs Soroban transactions - Propagated
inclusionFeeandresourceFeefrom simulation results through both send and collectible flows - Added "Calculating..." loading state for fees and a loading indicator on the continue button during simulation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| extension/src/popup/components/InternalTransaction/ReviewTransaction/index.tsx | New fees breakdown pane with fee detail rows and info button |
| extension/src/popup/components/InternalTransaction/ReviewTransaction/styles.scss | Styles for the fees breakdown pane and info button |
| extension/src/popup/components/send/SendAmount/index.tsx | Show "Calculating..." during simulation, loading state on button |
| extension/src/popup/components/send/SendAmount/hooks/useSimulateTxData.tsx | Pass inclusionFee and resourceFee from simulation |
| extension/src/popup/components/sendCollectible/SelectedCollectible/hooks/useSimulateTxData.ts | Pass inclusionFee and resourceFee from simulation |
| extension/src/popup/locales/en/translation.json | New i18n keys for fee breakdown UI |
| extension/src/popup/locales/pt/translation.json | Portuguese translations for new keys (with one regression) |
| @shared/api/internal.ts | Added network_url to simulate-tx request body |
| extension/e2e-tests/reviewTxFees.test.ts | E2E tests for fee breakdown in token, classic, and collectible sends |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
leofelix077
requested review from
CassioMG,
JakeUrban,
aristidesstaffieri,
piyalbasu and
sdfcharles
and removed request for
piyalbasu
leofelix077
changed the title
….com:stellar/freighter into feature/improve-resource-fee-display-on-send
leofelix077
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
extension/src/popup/components/InternalTransaction/ReviewTransaction/index.tsx
Show resolved
Hide resolved
extension/src/popup/components/InternalTransaction/FeesPane/index.tsx
Outdated
Show resolved
Hide resolved
extension/src/popup/components/InternalTransaction/FeesPane/index.tsx
Outdated
Show resolved
Hide resolved
leofelix077
added
enhancement
|
@leofelix077 looks nice! few notes: 
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@sdfcharles applied the adjustments to the UI parts now. thanks for checking! 
|
- Extract SimulateTxData interface to types/transactions.ts to remove duplicate definitions in send and collectible hooks - Both hooks now re-export the shared type - FeesPane and ReviewTransaction import directly from types/transactions - Fix FeesPane top/bottom padding and reset padding inside multi-pane-slider Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…//github.com/stellar/freighter into feature/improve-resource-fee-display-on-send
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2475
Screen.Recording.2026-03-13.at.11.42.36.mov
Screen.Recording.2026-03-13.at.11.43.27.mov