fix: implement client-side voice filtering #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1/voices API does not support the search query parameter, so searching for a voice by name (e.g., -v sarah) would return all voices and then incorrectly use the first unrelated voice as a "closest match". Changes: - ListVoices now filters results client-side by name substring - resolveVoice checks for exact match first, then substring match - Returns an error if no matching voice found instead of using an unrelated voice - Updated tests to verify actual name matching (not just first result) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1/voices API does not support the search query parameter, so searching for a voice by name (e.g., -v sarah) would return all voices and then incorrectly use the first unrelated voice as a "closest match".
Changes: