fix(escapeJsString): unbork code broken by prettier - fixes #514 #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revert's a prettier change which breaks the JS encoding of sources like c't. They get messed up to something like c\`t which Genios dutyfully acknowledges with a HTTP 400 Bad request. More see stefanw#514 Closes stefanw#514
bentolor
changed the title
Owner
|
Good catch, thank you! |
Contributor
Author
|
Danke für das schnelle Feedback und natürlich vor allem auch für BibBot, @stefanw ! Ich verzweifle (und habe aufgegeben) in meinen "normalen" Firefox ein unsigniertes Addon zum laufen zu bringen, darum bin ich natürlich besonders interessiert dass der Fix zeitnah in Upstream gelandet ist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revert's a prettier change which breaks the JS encoding of sources like c't. They get messed up to something like c`t which Genios dutyfully
acknowledges with a HTTP 400 Bad request.
More see #514
Closes #514