Conversation
requires occurrence-orig-binding branch of turnstile
TODO: Is there a better way to restrict non-overlapping types into bottom? Is it safe to say, no matter what, no two “base types” will have any values that overlap? TODO: Is there a better way to deal with known dead code (when propositions are bottom) than what’s done here? TODO: What should this do with Or propositions? (Right now they don’t add any information.) What about Not propositions?
to deal with converting the prop to an env, dead code, putting the correct scopes on the env identifiers, etc.
|
Thanks. Would changing |
|
No, merging stchang/macrotypes#12 would fix them. |
|
ok great. |
including fixing for/list to allow only concrete booleans for `#:when` and `#:unless` conditions
|
So the tests still fail even though stchang/macrotypes#12 is merged. Do you know what the cause is? |
|
Also, would you mind adding a line to travis.yml so it clones and tests your typed ocelot repo? Otherwise we're going to get out of sync |
|
The failures in old versions of racket are expected. Typed Rosette relies on a change I made to how generics work (racket/racket#1644), which is currently only there in 6.9 and HEAD. The failure on HEAD is weirder. There's just one test that's failing at runtime. It appears to be this one: (check-type (type-of s) : (C→ Any Bool) -> vector?) |
|
|
|
Hmm, I think the tests ran out of memory? Does ocelot have high requirements? |
|
Btw, I'm assuming this pr supercedes #9? |
|
Not sure what's going on with the tests. Only suggestion I could find is trying to reduce number of parallel jobs. Can you add |
|
And if reducing parallel jobs doesnt work, we can try to increase memory by setting |
|
Or you could give me access to your repo |
|
I added Also, I have the "Allow edits from maintainers" option turned on. |
2 participants
No description provided.