chore: fixed status-store node #82
Conversation
alvarobernal2412
left a comment
alvarobernal2412
left a comment
There was a problem hiding this comment.
I have revised a part of the node, however, due to its fragility it is better to revise it again in a meeting after making these corrections.
| defaults: { | ||
| name: { value: "" }, | ||
| backendUrl: { value: "" }, | ||
| backendUrl: { value: "http://status-backend:3001/api/v1/computations/bulk" }, // Default en JS y aquí |
There was a problem hiding this comment.
This comment should be removed
| bufferSize: { value: 2, validate: RED.validators.number() }, // Validar como número | ||
| flushInterval: { value: 2000, validate: RED.validators.number() }, // Validar como número | ||
|
|
||
| // Nuevas propiedades para la configuración global de la computación |
There was a problem hiding this comment.
These comments should be removed
| }, | ||
| inputs: 1, | ||
| outputs: 1, | ||
| outputs: 1, // El nodo ahora puede enviar mensajes de error/éxito por su salida |
There was a problem hiding this comment.
This comment should be removed
| return this.name || 'status-storer'; | ||
| }, | ||
| oneditprepare: function () { | ||
| // No hay lógica compleja de UI por ahora, pero se puede añadir aquí si es necesario |
There was a problem hiding this comment.
This comment should be removed
| // No hay lógica compleja de UI por ahora, pero se puede añadir aquí si es necesario | ||
| }, | ||
| oneditsave: function () { | ||
| // Lógica al guardar los cambios del nodo |
There was a problem hiding this comment.
This comment should be removed or written in English
| // Lógica al guardar los cambios del nodo | ||
| }, | ||
| oneditcancel: function () { | ||
| // Lógica al cancelar los cambios del nodo |
There was a problem hiding this comment.
This comment should be removed or written in English
| <label for="node-input-controlId"><i class="fa fa-id-badge"></i> Control ID</label> | ||
| <input type="text" id="node-input-controlId" placeholder="Control Identifier"> |
There was a problem hiding this comment.
The controlId should not be removed from the config parameters
| let backendUrl = config.backendUrl || "http://status-backend:3001/api/v1/computations/bulk"; | ||
| let accessToken = config.accessToken || ''; | ||
| let bufferSize = parseInt(config.bufferSize || 2); | ||
| let flushInterval = parseInt(config.flushInterval || 2000); | ||
|
|
||
| // Default properties for a computation group, if not provided per message. | ||
| let defaultComputationGroup = config.computationGroup || ''; | ||
| let defaultFrom = config.from || null; | ||
| let defaultTo = config.to || null; | ||
| let defaultControlId = config.controlId || null; |
There was a problem hiding this comment.
All the config parameters given by the node-red node must. handle the req.body option, so that if the system sends those parameters in the body, the node still works.
Example for parameter eventAName:
let eventAName = msg.req?.body?.eventAName ?? config.eventAName;…ce/node-red-status into status-storer-fix
…ce/node-red-status into status-storer-fix
alvarobernal2412
force-pushed
the
main
branch
4 times, most recently
from
95b428b to
829a83e
Compare
alvarobernal2412
force-pushed
the
main
branch
6 times, most recently
from
b813d0b to
b661390
Compare
alvarobernal2412
force-pushed
the
main
branch
from
b8ab5ef to
730d151
Compare
No description provided.