feat: sds unwrapping #7227
Merged
feat: sds unwrapping #7227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (134)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7227 +/- ##
===========================================
+ Coverage 60.35% 60.37% +0.02%
===========================================
Files 814 815 +1
Lines 113082 113163 +81
===========================================
+ Hits 68249 68321 +72
- Misses 37762 37778 +16
+ Partials 7071 7064 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
2494050 to
821069e
Compare
igor-sirotin
changed the base branch from
develop
to
fix/test-messenger-cleanup
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
821069e to
b44643f
Compare
igor-sirotin
force-pushed
the
fix/test-messenger-cleanup
branch
from
4a367d6 to
1748e14
Compare
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
b44643f to
b300be1
Compare
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
b300be1 to
026c3d3
Compare
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
2675b3b to
e43ad91
Compare
jrainville
approved these changes
Dec 22, 2025
Ivansete-status
approved these changes
Dec 22, 2025
Contributor
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 💯
* feat: enable sds for wrap message * chore: add sds default flag * feat: enable sds for public community message * fix: always set community id * feat: add message ID for public params * chore: move sds to reliability * chore: refactor flags * chore: add unit test for sds * chore: fix test * chore: add test-single helper * chore: update Makefile Co-authored-by: Igor Sirotin <[email protected]> * chore: update logs Co-authored-by: Igor Sirotin <[email protected]> * chore: refactor function name for init sds * chore: merge upstream * chore: refactor sds processor * chore: move sds wrap logic to messaging sender. * chore: refactor sds manager * chore: disable sds wrap * fix: disable Nim signal handler --------- Co-authored-by: Igor Sirotin <[email protected]>
igor-sirotin
force-pushed
the
feat/sds-unwrapping
branch
from
e43ad91 to
ca8d9f0
Compare
igor-sirotin
added a commit
that referenced
this pull request
Dec 23, 2025
* feat: Add SDS unwrap process for received messages (#7149) * feat: enable sds for wrap message * chore: add sds default flag * feat: enable sds for public community message * fix: always set community id * feat: add message ID for public params * chore: move sds to reliability * chore: refactor flags * chore: add unit test for sds * chore: fix test * chore: add test-single helper * chore: update Makefile Co-authored-by: Igor Sirotin <[email protected]> * chore: update logs Co-authored-by: Igor Sirotin <[email protected]> * chore: refactor function name for init sds * chore: merge upstream * chore: refactor sds processor * chore: move sds wrap logic to messaging sender. * chore: refactor sds manager * chore: disable sds wrap * fix: disable Nim signal handler --------- Co-authored-by: Igor Sirotin <[email protected]> * fix: cleanup sds manager * feat: set sds logger * chore: update sds-go-bindings * test: named loggers * test: TestSdsFileDescriptors * chore: vendor hash * feat: support updating nim-sds * fix: TestSdsFileDescriptors skip comment * chore: bump sds-go-bindings * chore: bump nim-sds * chore: vendor hash
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Closes:
Description
Cleanup()on reliabilityStop().nim-sdsto get feat: thread pool logos-messaging/nim-sds#40sds-go-bindingsto get fix: remove global logger logos-messaging/sds-go-bindings#9nim-sdsversion.