apollo_network: pass the reBadPeerReport when reporting #12474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches cross-crate networking interfaces and call sites; behavior should be equivalent but signature changes and new report construction could break integrations or misclassify peers if wired incorrectly.
Overview
Updates the broadcast peer-reporting API so
BroadcastTopicClientTrait::report_peernow requires aBadPeerReport(peer id,BadPeerReason, andPenaltyCard) alongside the originalBroadcastedMessageMetadata.Consensus and mempool P2P are updated to construct and pass structured reports for specific cases (e.g., vote/tx conversion failures and duplicate votes), tests/mocks are adjusted accordingly, and the network crate docs/tests are updated; the current
BroadcastTopicClient::report_peerstill only forwards the metadata while logging the report (TODO to send it).Written by Cursor Bugbot for commit a921ad3. This will update automatically on new commits. Configure here.