starknet_os: refactor create commitment infos to not panic #12460
+46
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Yoni-Starkware
approved these changes
Feb 10, 2026
Collaborator
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).
AvivYossef-starkware
force-pushed
the
refactor_create_commitment_info_to_not_panic
branch
from
87e3132 to
fa09ff1
Compare
AvivYossef-starkware
force-pushed
the
aviv/validate_state_diff
branch
from
be720b7 to
7270d5c
Compare
AvivYossef-starkware
changed the base branch from
aviv/validate_state_diff
to
main-v0.14.2
AvivYossef-starkware
force-pushed
the
refactor_create_commitment_info_to_not_panic
branch
from
fa09ff1 to
30c73a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Behavior is largely unchanged except failures now propagate as typed errors instead of
unwrap()panics; risk is limited to changed error surfaces for callers.Overview
Refactors
create_commitment_infosand helpers to stop panicking on invalid data / DB/proof failures by introducingCommitmentInfosErrorand returningResult, propagating errors from leaf fetching, proof traversal, and node-index conversions.Updates call sites in flow tests and the runner: tests now
.unwrap(), whilestarknet_os_runnermaps failures intoProofProviderErrorinstead of crashing.Written by Cursor Bugbot for commit 30c73a1. This will update automatically on new commits. Configure here.