-
Notifications
You must be signed in to change notification settings - Fork 64
deployment: create action composite for namespace cache on bootstrap #12379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deployment: create action composite for namespace cache on bootstrap #12379
Conversation
1cea5d4 to
d21a364
Compare
phil-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phil-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware).
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware reviewed 5 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @idan-starkware).
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware).
78dac67 to
60b4978
Compare
e6dca09 to
097617f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
097617f to
4bbbbec
Compare
91d36d7 to
dd2cb8b
Compare
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware partially reviewed 2 files.
Reviewable status: 3 of 18 files reviewed, all discussions resolved.
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware reviewed all commit messages.
Reviewable status: 3 of 18 files reviewed, all discussions resolved.
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware partially reviewed 6 files.
Reviewable status: 6 of 18 files reviewed, all discussions resolved.
idan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-starkware reviewed 12 files.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware).
528be8e
Note
Medium Risk
CI-only changes but they alter caching and benchmarking checkout/working-directory behavior across many workflows, which can cause flaky builds or incorrect benchmark comparisons if misconfigured.
Overview
Adds a new composite action
namespace_cacheand wires it intobootstrap, centralizing Namespace cache volume mounting for both Rust (/home/runner/.cargo) and Python.Updates CI workflows to use
actions/checkout@v6, adjusts runner sizes for heavier jobs, and refactors benchmarking jobs to checkout the PR branch into a separate subdirectory and copy the basecriterionbaseline sorun-and-compareoperates on the correct workspace without overwriting base-branch composite actions. Removes the Rust cache mount step frominstall_rustand drops unused outputs fromsetup_native_deps.Written by Cursor Bugbot for commit dd2cb8b. This will update automatically on new commits. Configure here.