apollo_starknet_os_program: remove keccak syscall from virtual OS #12355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
AvivYossef-starkware
approved these changes
Feb 8, 2026
Contributor
AvivYossef-starkware
left a comment
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).
Yoni-Starkware
force-pushed
the
yonatan/remove-keccak-virtual-os
branch
3 times, most recently
from
f829cd2 to
b98f6d8
Compare
Yoni-Starkware
force-pushed
the
yonatan/remove-keccak-virtual-os
branch
from
b98f6d8 to
dc89714
Compare
Yoni-Starkware
commented
Feb 8, 2026
Collaborator
Author
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove keccak syscall support from the Virtual OS to reduce its footprint.
Note
Medium Risk
Changes virtual-OS syscall surface and program hashes, so any client-side proving/verification and tooling that still expects
Keccakin virtual mode or the old hashes will break until updated.Overview
Removes
Keccaksyscall support from the Virtual OS by deleting the selector import and dispatch branch inexecute_syscalls__virtual.cairo, reducing the virtual OS program footprint.Updates all allowlists and hash pins to the newly built virtual OS:
ALLOWED_VIRTUAL_OS_PROGRAM_HASHES(Cairo constants),program_hash.json(osandvirtual_os), and Blockifier’sallowed_virtual_os_program_hashesconstants/diff regression data. Adjusts tests to reflect the new virtual OS bytecode length and resulting gas expectation deltas inbouncer_test.rs.Written by Cursor Bugbot for commit dc89714. This will update automatically on new commits. Configure here.